Be more explicit about not being logged in on 404 error page #9766

daniel-beck · 2024-09-20T18:10:24Z

A recent comment in https://issues.jenkins.io/browse/JENKINS-21813 (which IMO was taken care of by #8250) brought up that it's not really easy to tell you're not logged in, just a difference in the header.

So this makes that more obvious. Suggestions for wording welcome.

Testing done

Before

https://ci.jenkins.io/lol

After

Proposed changelog entries

Too minor?

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

timja · 2024-09-22T21:30:43Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

janfaracik · 2024-09-26T12:24:44Z

Not blocking - would it be worth including a link to log in in the message?

daniel-beck · 2024-10-01T17:04:20Z

would it be worth including a link to log in in the message?

Likelihood of success is too low to attempt: loginLink.jelly can be overridden by security realms to have custom content.

Be more explicit about not being logged in on 404 error page

4da013c

timja approved these changes Sep 22, 2024

View reviewed changes

timja added the skip-changelog Should not be shown in the changelog label Sep 22, 2024

NotMyFault approved these changes Sep 22, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 22, 2024

MarkEWaite merged commit 4759f1a into jenkinsci:master Oct 2, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Be more explicit about not being logged in on 404 error page #9766

Be more explicit about not being logged in on 404 error page #9766

daniel-beck commented Sep 20, 2024 •

edited

Loading

Submitter checklist

Maintainer checklist

timja commented Sep 22, 2024

janfaracik commented Sep 26, 2024

daniel-beck commented Oct 1, 2024

Be more explicit about not being logged in on 404 error page #9766

Be more explicit about not being logged in on 404 error page #9766

Conversation

daniel-beck commented Sep 20, 2024 • edited Loading

Testing done

Before

After

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja commented Sep 22, 2024

janfaracik commented Sep 26, 2024

daniel-beck commented Oct 1, 2024

daniel-beck commented Sep 20, 2024 •

edited

Loading